Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set cssFilename to make ecosystem-ci pass #768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sapphi-red
Copy link
Contributor

Description

Vite 6 now aligns the CSS file name with the JS file name for lib mode (vitejs/vite#18488).
I set cssFilename to make the repo compatible with Vite 6 and pass the ecosystem-ci (only partially as vite-plugin-svelte for Vite v6 is not released yet).

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

codesandbox bot commented Nov 20, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Nov 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for histoire-site failed.

Name Link
🔨 Latest commit 5a29a3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/673d732b5e36b80008faa192

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit 5a29a3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/673d732bae54fb00088df7cf

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit 5a29a3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/673d732b4f30a700082d595f

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 5a29a3b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/673d732b00e9e80008f83043

Copy link

pkg-pr-new bot commented Nov 20, 2024

Open in Stackblitz

histoire

pnpm add https://pkg.pr.new/histoire-dev/histoire@768

@histoire/app

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/app@768

@histoire/controls

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/controls@768

@histoire/plugin-nuxt

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-nuxt@768

@histoire/plugin-percy

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-percy@768

@histoire/plugin-screenshot

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-screenshot@768

@histoire/plugin-svelte

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-svelte@768

@histoire/plugin-vue

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-vue@768

@histoire/plugin-vue2

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-vue2@768

@histoire/shared

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/shared@768

@histoire/vendors

pnpm add https://pkg.pr.new/histoire-dev/histoire/@histoire/vendors@768

commit: 5a29a3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant