Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update tsdoc comments to expose internal methods #1761

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: update tsdoc comments to expose internal methods #1761

merged 2 commits into from
Nov 14, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Nov 14, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 7.0.2-pr.1+c82f2edf
e.g. npm install @stacks/[email protected]+c82f2edf --save-exact

  • update tsdocs to remove @internal where not needed

@janniks janniks requested a review from rafaelcr November 14, 2024 14:50
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 3:00pm

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@janniks janniks changed the title refactor: update internal markings fix: update tsdoc comments to expose internal methods Nov 14, 2024
rafaelcr
rafaelcr approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janniks janniks merged commit 2f2b12b into main Nov 14, 2024
10 checks passed
@janniks janniks deleted the fix/import-marking branch November 14, 2024 15:05
@blockstack-devops blockstack-devops mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @rafaelcr