Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the bitcoin rpc library used to support newer bitcoin version #429

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

change the bitcoin rpc library used to support newer bitcoin version #429

wants to merge 2 commits into from

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Feb 14, 2025 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/ordhook-core/src/utils/bitcoind.rs 0.00% 3 Missing ⚠️
components/chainhook-sdk/src/serde_hex.rs 60.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 14, 2025 17:06 — with GitHub Actions Error
rafaelcr
rafaelcr reviewed Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! We should test it on dev before merging

@rafaelcr
Copy link
Collaborator

Can you link the issue you're closing to this PR? So it closes upon merge -> #411

@ASuciuX ASuciuX self-assigned this Feb 14, 2025
@rafaelcr rafaelcr requested a deployment to Development-mainnet-blue February 17, 2025 16:33 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr left review comments

Assignees

@ASuciuX ASuciuX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with outdated RPC library
2 participants
@ASuciuX @rafaelcr