Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Switch to SIP-030 #403

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

feat!: Switch to SIP-030 #403

wants to merge 42 commits into from

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jan 14, 2025 •
edited
Loading

This PR was published to npm with versions:

New JSON RPC Interface

  • Add new JSON RPC APIs and types (e.g. stx_signMessage)
    • These consist of: method, params, and response types.
  • Deprecate but keep most legacy methods, to avoid breaking as much as possible for dApps
  • Add TypeBox and Zod schemas for wallets and apps to validate. These might be added later.

Apologies for the large diff. The gist of this pull request is switching away from the JWT token-based API to the new JSON RPC-based API. However, we want to stay largely backwards compatible with the previous connect version, even though this will be a breaking change. And thus many no-op functions and types are still included. Sometimes even slightly broken behaviors kept for ease of dApp developer experience.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8a0b7bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@stacks/connect-react Major
@stacks/connect Major
@stacks/connect-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 5:12pm
connect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 5:12pm

@friedger friedger mentioned this pull request Jan 21, 2025
Open
@janniks janniks force-pushed the feat/switch-to-sip-030 branch from df0640c to 37ca344 Compare February 10, 2025 10:17
@janniks
Merge branch 'main' into feat/switch-to-sip-030
f4692ec 
# Conflicts:
#	package-lock.json
#	packages/connect/src/stories/ConnectPage.tsx
#	packages/connect/src/stories/connect.css
@janniks janniks force-pushed the feat/switch-to-sip-030 branch from 37ca344 to f4692ec Compare February 10, 2025 10:18
@janniks janniks marked this pull request as ready for review February 10, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedger friedger friedger left review comments

@beguene beguene beguene left review comments

@kyranjamie kyranjamie kyranjamie left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janniks @friedger @beguene @kyranjamie