HP-1581: fix 'Creation of dynamic property hiqdev\hiart\stream\Response::$version is deprecated'

[VadymHrechukha]

Summary by CodeRabbit

• New Features
  • Enhanced HTTP response handling with improved protocol version detection and tracking.

[coderabbitai]

Walkthrough

The Response class now captures the HTTP protocol version during status line parsing. A new protected $version property stores the protocol version alongside the existing statusCode and reasonPhrase attributes.

Changes

Cohort / File(s)	Summary
HTTP Version Capture src/stream/Response.php	Added protected $version property to store HTTP protocol version parsed from status lines

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A version, now captured with care,
In Response, stored with protocol flair,
No more is the HTTP version lost,
Through parsing, we've tracked it with cost!
The rabbit hops onward, version complete! 🌿

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title directly and accurately describes the primary change being made. The title references fixing a deprecation warning about the dynamic creation of a $version property on the Response class, which aligns perfectly with the actual changeset that adds a protected $version property declaration to the class. This approach prevents PHP from creating the property dynamically, thus resolving the deprecation warning. The title is specific, clear, and includes the issue number (HP-1581) for traceability, allowing teammates reviewing history to immediately understand the purpose of the change.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[VadymHrechukha]

https://sentry.hiqdev.com/organizations/hiqdev/issues/72294

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/stream/Response.php (1)

62-65: Add bounds checking for status line parsing.

Accessing array elements without verifying their existence can cause undefined array key warnings if the HTTP status line is malformed (e.g., missing reason phrase or status code).

Apply this diff to add bounds checking:

             if (strncmp($header, 'HTTP/', 5) === 0) {
                 $parts = explode(' ', $header, 3);
-                $this->version = substr($parts[0], 5);
-                $this->statusCode = $parts[1];
-                $this->reasonPhrase = $parts[2];
+                $this->version = isset($parts[0]) ? substr($parts[0], 5) : null;
+                $this->statusCode = $parts[1] ?? null;
+                $this->reasonPhrase = $parts[2] ?? null;
             } elseif (($pos = strpos($header, ':')) !== false) {

🧹 Nitpick comments (1)

src/stream/Response.php (1)

30-30: Good fix for PHP 8.2 deprecation.

The explicit property declaration resolves the deprecation warning. Consider adding a docblock to document what version information is stored (e.g., "1.1" from "HTTP/1.1").

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c4a0dc and 2cff965.

📒 Files selected for processing (1)

• src/stream/Response.php (1 hunks)