🛡️ Sentinel: [CRITICAL] Fix Server-Side Request Forgery (SSRF) and Resource Leak in plugin downloader - #228
🛡️ Sentinel: [CRITICAL] Fix Server-Side Request Forgery (SSRF) and Resource Leak in plugin downloader#228himattm wants to merge 1 commit into
Conversation
Implements a custom HTTP client with a dialer control hook to explicitly block connections to the AWS metadata IP (169.254.169.254), mitigating Server-Side Request Forgery (SSRF) when fetching plugins from user-provided URLs. Also sets DisableKeepAlives to true to prevent idle connection resource leaks. Co-authored-by: himattm <6266621+himattm@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
addFromDirectURLfunction fetches plugins from user-provided URLs without restricting the resolved IP address, leading to SSRF. Furthermore,http.Getleaves connection keep-alives enabled, which leaks resources for one-off requests.🎯 Impact: An attacker could force the server to make requests to cloud metadata services (e.g.,
169.254.169.254). Also, idle connections were leaking.🔧 Fix: Implemented a custom HTTP client with a dialer control hook to explicitly block connections to cloud metadata IPs, while allowing legitimate local CLI traffic. Set
DisableKeepAliveson the transport to prevent idle connection leaks.✅ Verification: Ensured the code compiles and tests pass.
PR created automatically by Jules for task 6213845225528321902 started by @himattm