MM-001 normalize noisy Android layout output - #2
Draft
himattm wants to merge 1 commit into
Draft
Conversation
Reproduction: android layout emits a JSON-encoded element array followed by an update notice; minimap layout previously returned the combined stdout as a string. Normalize clean, legacy-root, and encoded layout values to an object array, report Android CLI notices separately, and apply the parser to selector taps and cached layouts. Verified with the exact CLI contract regression, cargo test --workspace, cargo clippy --all-targets -- -D warnings, cargo fmt --check, and the minimap-cli binary build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Normalize every successful Android CLI layout response into a JSON array of element objects. The parser now handles clean arrays, legacy root objects, recursively JSON-encoded output, and update notices before or after the payload. Notices are returned separately as
android_cli_notices.Why
Android CLI sometimes returned a JSON string containing an encoded layout followed by upgrade text. Minimap passed that representation through, forcing callers to parse inconsistent types.
Impact
Consumers can always treat
layoutas an array and can inspect non-layout CLI notices without contaminating selector input.Validation
cargo test --workspacecargo clippy --all-targets -- -D warningscargo fmt --all -- --checkcargo build -p minimap-cli --bin minimapStack
Base:
codex/lean-minimap-navigation-graph