-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding multi-discrete pretraining #407
base: master
Are you sure you want to change the base?
Conversation
Hello, thanks for the PR, please do not forget to read the contributing guide first ;) |
Okay, sorry! I'll go check it out. Sorry in the middle of finishing a late NeurIPS review :S |
I think I've followed the steps (ran the tests, etc) I can't seem to find a change-log. Is there anything else I am missing? |
The changelog is in the doc and you should add a test that check that new feature. |
And next time, please open an issue first, so we can discuss the feature. |
Okay got it :) Sorry again to bother! |
I can think of any multi-discret environments packaged with OpenAI gym. I'm currently using We could potentially add the |
I think a variation of the identity env (in the common folder) should make the trick. |
This PR should also include a change to generate_expert_traj(), right? |
I would say yes. |
Adds multi-discrete action space support to pretraining.