start rewrite #8
Conversation
| # Thumbnails | ||
| ._* | ||
|
|
||
| # Files that might appear in the root of a volume |
There was a problem hiding this comment.
Why would all these excludes for root/AFP be necessary? Just curious.
There was a problem hiding this comment.
Iuse the template from https://marketplace.visualstudio.com/items?itemName=codezombiech.gitignore and they seem to work for me just fine - of course its 90% not relevant for the project but they are good defaults
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/highlightjs/highlightjs-supercollider.git" | ||
| "url": "git+https://github.com/highlightjs/highlightjs-cypher.git" |
There was a problem hiding this comment.
thx for the hint, forgot to change it - copied from cypher and transfered the existing supercollider source code then.
package.json
Outdated
| }, | ||
| "homepage": "https://github.com/highlightjs/highlightjs-supercollider#readme", | ||
| "author": "Dennis Scheiba", | ||
| "license": "GPL-2.0", |
There was a problem hiding this comment.
Shouldn't bugs or homepage just point to GitHub?
src/sclang.js
Outdated
| ); | ||
|
|
||
| return { | ||
| aliases: ["supercollider", "sc", "sclang"], |
There was a problem hiding this comment.
Thx for the advice. Just as a reminder, both reference examples lack the name parameter
- https://github.com/highlightjs/highlightjs-cypher/blob/master/src/cypher.js
- https://github.com/highlightjs/highlightjs-robots-txt/blob/master/src/robots-txt.js
Maybe add them there as well?
src/sclang.js
Outdated
| ); | ||
|
|
||
| return { | ||
| aliases: ["supercollider", "sc", "sclang"], |
There was a problem hiding this comment.
sclang doesn't need to be listed as an alias when it's the actual name.
|
Thanks for the review, I hope everything is fine now :) |
Brings it to working condition again :)