Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) min change threshold for size report #3401

Merged
merged 1 commit into from
Feb 1, 2022
Merged

(chore) min change threshold for size report #3401

merged 1 commit into from
Feb 1, 2022

Conversation

bradleymackey
Copy link
Contributor

@bradleymackey bradleymackey commented Nov 14, 2021 •
edited
Loading

±5 byte threshold to avoid reports for hash changes and tiny edits.

Changes

  • GitHub workflow change only.

Checklist

@joshgoebel
Copy link
Member

Shouldn't we et a size report for this change? (even though it obviously won't change anything)

@bradleymackey
Copy link
Contributor Author

It looks like the workflow ran - it probably doesn't comment if there's no changes.

@joshgoebel
Copy link
Member

Error: compressed-size-action was unable to comment on your PR.
489
This can happen for PR's originating from a fork without write permissions.

@bradleymackey
Copy link
Contributor Author

I'll look into this a bit more to see if there's a workaround in GitHub actions - I apologise for this oversight.

@bradleymackey bradleymackey marked this pull request as draft November 15, 2021 09:48
@joshgoebel
Copy link
Member

preactjs/compressed-size-action#54

@joshgoebel
Copy link
Member

I'll look into this a bit more to see if there's a workaround in GitHub actions - I apologise for this oversight.

Did you learn anything?

@joshgoebel joshgoebel marked this pull request as ready for review February 1, 2022 04:48
@joshgoebel
Copy link
Member

I'm merging since it's the right idea, even if it's not working properly yet.

@joshgoebel joshgoebel merged commit d8cf962 into highlightjs:main Feb 1, 2022
brainlid added a commit to brainlid/highlight.js that referenced this pull request Feb 11, 2022
@brainlid
Merge branch 'master' into customized-elixir
7dbe12d 
* master: (816 commits)
  (chore) add sideEffects: false to enable tree-shaking in esbuild & others
  fix(markdown) Handle `***Hello world***` without breaking (highlightjs#3457)
  (chore) DRY up php grammar just a little
  enh(php) support CSSCase attribute naming
  refactor, security issues
  enh(php) Add support for Attributes
  fix(java) prevent false variable init on `else` (highlightjs#3455)
  (ci) min change threshold for size report (highlightjs#3401)
  (themes) Add `tokyo-night-dark` (highlightjs#3467)
  enh(llvm) Improve number support, add `char.escape` (highlightjs#3471)
  (chore) simplify brainfuck grammar
  fix(brainfuck) fix highlighting of initial ++/--
  Minor change to TypeScript types and TypeScript-specific keywords (highlightjs#3466)
  fix(angelscript) Fix highlighting of int8, int16, int32, int64 (highlightjs#3464)
  enh(php) named arguments and fix php constants (highlightjs#3459)
  themes: add new felipec theme (highlightjs#3441)
  (chore) release 10.4.0
  enh(arcade) Add missing keywords for Arcade v1.16
  chore(arcade) eslint --fix, explode keywords
  enh(php) Left and right-side of double colon (highlightjs#3422)
  ...
@bradleymackey
Copy link
Contributor Author

@joshgoebel Sorry for never getting round to this, this project fell off my radar for a bit! I'll still try to look into this after I work on a few outstanding grammar-level changes needed to Swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradleymackey @joshgoebel