Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update the merge requirement for tck #255

Merged

Conversation

CodeLeom
Copy link
Contributor

@CodeLeom CodeLeom commented Oct 7, 2024

Description:
update the merge requirement for sdk tck

Related issue(s):
closes 235
Fixes #
#235
Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@CodeLeom
Copy link
Contributor Author

CodeLeom commented Oct 7, 2024

@rwalworth I had to open a new PR. I closed the previous PR and reopen another. I followed the last instruction, but I noticed it reverted the changes back to the initial and the merge was now done automatic. It will be merged completed but it will be realized in the future, so I had to close the PR and reopen this.

@jsync-swirlds
Copy link
Contributor

@rwalworth I had to open a new PR. I closed the previous PR and reopen another. I followed the last instruction, but I noticed it reverted the changes back to the initial and the merge was now done automatic. It will be merged completed but it will be realized in the future, so I had to close the PR and reopen this.

It can be tricky to meet Github GPG and DCO requirements after the fact. For a simple PR, in particular, this close-and-reopen-with-fixed-commit is often the easiest solution.

Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the effort and for going through the headache of signing commits, still LGTM!

@rwalworth rwalworth merged commit 927fe53 into hiero-ledger:main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants