Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add test specifications for TokenCreateTransaction #228

Merged
merged 29 commits into from
Oct 3, 2024
Merged

docs: Add test specifications for TokenCreateTransaction #228

merged 29 commits into from
Oct 3, 2024

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds the tests for TokenCreateTransaction, which tests every field for valid and invalid entries.

Related issue(s):

Fixes #139

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the documentation Improvements or additions to documentation label Jul 19, 2024
@rwalworth rwalworth self-assigned this Jul 19, 2024
@rwalworth rwalworth linked an issue Jul 19, 2024 that may be closed by this pull request
Document E2E tests: TokenCreateTransaction #139
Closed
@rwalworth rwalworth mentioned this pull request Aug 13, 2024
Merged
2 tasks
@rwalworth
docs: be consistent with account ID names
aa9ada8 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: kyc key doesn't need to sign to be added to a new token
772c6c6 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: remove signers from key tests
b263ae6 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: creating a token with freezeDefault=true requires a freeze key
de0f180 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: update docs based on running tests
5f71ac7 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: add initial supply NFT test
7ce9acb 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: add freeze default test
8d73283 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: fix typo
ff5d35f 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: add autoRenewAccount test
a6bfed9 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: fix typos
f2a68ac 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: fix incorrect network response
6ee6d9a 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: add more cases for int types
7dd12e1 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: fix decimals tests
24b91f0 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: add bounds testing for fee fields
b15f197 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: fix tests
a488e24 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
docs: update language in some tests
93e0882 
Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
Merge branch 'main' into 00139-document-e2e-tests-tokencreatetransaction
35bc141
0xivanov
0xivanov approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gsstoykov
gsstoykov approved these changes Oct 2, 2024
View reviewed changes
Copy link

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

test-specifications/token-service/tokenCreateTransaction.md Show resolved Hide resolved
@rwalworth rwalworth merged commit e12e73d into main Oct 3, 2024
3 checks passed
@rwalworth rwalworth deleted the 00139-document-e2e-tests-tokencreatetransaction branch October 3, 2024 15:13
ivaylogarnev-limechain pushed a commit that referenced this pull request Oct 4, 2024
@rwalworth @jsync-swirlds @ivaylogarnev-limechain
docs: Add test specifications for TokenCreateTransaction (#228)
db57f3f 
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

@0xivanov 0xivanov 0xivanov approved these changes

@thenswan thenswan Awaiting requested review from thenswan

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

@RickyLB RickyLB Awaiting requested review from RickyLB

@agadzhalov agadzhalov Awaiting requested review from agadzhalov

@Petyo-Lukanov Petyo-Lukanov Awaiting requested review from Petyo-Lukanov

@svetoslav-nikol0v svetoslav-nikol0v Awaiting requested review from svetoslav-nikol0v

@jsync-swirlds jsync-swirlds Awaiting requested review from jsync-swirlds

Assignees

@rwalworth rwalworth

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document E2E tests: TokenCreateTransaction
4 participants
@rwalworth @0xivanov @jsync-swirlds @gsstoykov