-
Notifications
You must be signed in to change notification settings - Fork 18
fix: add HCS message query integration test #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add HCS message query integration test #74
Conversation
Signed-off-by: Alexander Shenshin <[email protected]>
Signed-off-by: Alexander Shenshin <[email protected]>
.github/workflows/test.yml
Outdated
@@ -29,7 +29,7 @@ jobs: | |||
|
|||
- name: Prepare Hiero Solo | |||
id: solo | |||
uses: hiero-ledger/hiero-solo-action@35efe2334bffb73298716402a5c688321ec29260 # v0.6 | |||
uses: AlexanderShenshin/hiero-solo-action@v0.0.5-dev # Tagged version from fork, reflects upstream PR: https://github.com/hiero-ledger/hiero-solo-action/pull/37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary change o fork, will not be needed once hiero-ledger/hiero-solo-action#37 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's in that case wait until your solo-actions PR is merged, will try to chase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @AlexanderShenshin: could we change this to the newest solo version so we can merge it in? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderShenshin. I have just merged solo action v0.8, please refactor for the final review when you can. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderShenshin: any updates on this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nadineloepfe, @exploreriii !
Sorry for late response, I was on vacation.
I removed usage of forked Hiero Solo action + created a separate integration test for HCS Message Query.
However, it looks like the issue still persists - the test passes against testnet (checked locally), but not against solo network that we use in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so seems to be a problem with the solo mirror node. it probably doesn't have enough time to fetch the topics. can we try the following?
- increasing MESSAGE_WAITING_TIMEOUT to like 60s
- increasing the sleep time in
test_integration_topic_message_query_returns_all_messages
before querying (await asyncio.sleep(60)
or smth like that)
if that doesn;t fix it then we need to check if the connection to localhost:5600 is established, as looking through the logs the the network.py seems to be still correctly configured @AlexanderShenshin
Signed-off-by: Alexander Shenshin <[email protected]>
Signed-off-by: Alexander Shenshin <[email protected]>
Signed-off-by: Alexander Shenshin <[email protected]>
5d1062c
to
09e6ab6
Compare
Hi @AlexanderShenshin : any new regarding this PR? thanks |
Signed-off-by: Alexander Shenshin <[email protected]>
Signed-off-by: Alexander Shenshin <[email protected]>
Hi @nadineloepfe! I've tried to increase timeouts/wait time and using a recently updated version of Hiero Solo - doesn't fix the issue. Query returns some messages, but not all of them and it's unstable (with 60 seconds timeout it returned 2 out of 3 and with 120 seconds - 1 out of 3). All other tests are working and, based on my initial observations in DID SDK, only HCS messages resolution is affected. So it seems that there is a specific issue with querying messages from Hiero Solo mirror node. Sorry, I don't have enough time to debug this further at the moment (and this is a bit out of scope for me, to be honest). |
Description:
Adds HCS message query part for integration tests, currently can be used as reproduction sample for: #75
Related issue(s): #75
Checklist