fix: eth_sendRawTransaction now handles malformed RLP data correctly #3714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re now handled correctly Signed-off-by: Simeon Nakov <[email protected]>
Test Results 24 files + 4 317 suites +62 52m 16s ⏱️ + 11m 27s For more details on these failures, see this check. Results for commit faa0fea. ± Comparison against base commit b882f71. ♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
requested changes
Apr 22, 2025
quiet-node
requested changes
Apr 22, 2025
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
reviewed
Apr 23, 2025
Signed-off-by: Simeon Nakov <[email protected]>
| @@ -195,6 +195,18 @@ describe('@ethSendRawTransaction eth_sendRawTransaction spec', async function () | |||
| ); | |||
| }); | |||
|
|
|||
| it('should return a predefined INVALID_ARGUMENTS when transaction has invalid format', async function () { | |||
| const invalidTx = | |||
| '0xf8748201280585800e8dfc0085800e8dfc00832dc6c094aca85ef7e1fce27079bbf99b60fcf6fd19b99b248502540be40080c001a0210446cfb671c3174392410d52fa3cd58723d8417e40cc67c6225b8f7e3ff693a02674b392846c59f783ea96655d39560956dd987051972064a5d853cea0b6f6d711'; | |||
There was a problem hiding this comment.
May we add a comment on exactly how is this tx invalid
quiet-node
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In this PR, the
eth_sendRawTransactionlogic now handles malformed RLP data correctly by checking for INVALID_ARGUMENT error and returning a predifined error and 400 status code.Related issue(s):
Fixes #3652
Checklist