feat: improves eth_getCode caching #3698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 23 files - 1 271 suites - 59 37m 7s ⏱️ - 10m 15s For more details on these failures, see this check. Results for commit 2a05e8f. ± Comparison against base commit 4fa65dc. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
konstantinabl
requested changes
Apr 17, 2025
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
| // First call with 'latest' should make network calls | ||
| await ethImpl.getCode(CONTRACT_ADDRESS_1, 'latest', requestDetails); | ||
| const afterFirstGetCount = restMock.history.get.length; | ||
| expect(afterFirstGetCount).to.be.greaterThan(initialGetCount); |
There was a problem hiding this comment.
@simzzz Can we make this test slightly more specific. e.g instead of checking if its greater than we may expect an exact count, or maybe just check if the cache service is not called at all.
There was a problem hiding this comment.
I made an improvement that I think makes it more clear now. You can take a look @konstantinabl
Signed-off-by: Simeon Nakov <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the caching for
eth_getCodeby caching even with prohibited opcodes, and removing caching for blockNumber === latestRelated issue(s):
Fixes #3634
Checklist