fix: added check for positive amount

[mdqst]

Description:

Added a check to ensure amount is greater than zero, preventing transfers with invalid or zero amounts.

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[quiet-node]

Hey @mdqst thanks for opening the PR! The team will get to review this PR soon. In the meantime, could you please create a GitHub issue detailing the project’s problem and kindly link it to this PR? We enforce this pattern to ensure every PR is associated with an issue, providing clear context for future reference if revisiting the changes is needed.

[quiet-node]

Hey @mdqst hope things are going fine for you. Just wanted to make sure you got this message #3588 (comment) above

[mdqst]

The team will get to review this PR soon. In the meantime, could you please create a GitHub issue detailing the project’s problem and kindly link it to this PR? We enforce this pattern to ensure every PR is associated with an issue, providing clear context for future reference if revisiting the changes is needed.

I want to emphasize that adding the check for a positive amount is critical to prevent errors when attempting to perform a transaction with a zero or negative amount. Without this check, the system might process invalid transactions, leading to unwanted consequences. This PR addresses that issue and improves system stability.

I believe this change should be merged as soon as possible to prevent potential issues in the future.

[quiet-node]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #3588   +/-   ##
=======================================
  Coverage        ?   35.02%           
=======================================
  Files           ?       71           
  Lines           ?     4637           
  Branches        ?      979           
=======================================
  Hits            ?     1624           
  Misses          ?     2786           
  Partials        ?      227           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[quiet-node]

The team will get to review this PR soon. In the meantime, could you please create a GitHub issue detailing the project’s problem and kindly link it to this PR? We enforce this pattern to ensure every PR is associated with an issue, providing clear context for future reference if revisiting the changes is needed.

I want to emphasize that adding the check for a positive amount is critical to prevent errors when attempting to perform a transaction with a zero or negative amount. Without this check, the system might process invalid transactions, leading to unwanted consequences. This PR addresses that issue and improves system stability.

I believe this change should be merged as soon as possible to prevent potential issues in the future.

@mdqst I understand the critical impact, but please create a new issue describing the problem and link it to the PR. Otherwise, the PR label and milestone checks will fail: https://github.com/hiero-ledger/hiero-json-rpc-relay/actions/runs/14062654716/job/40201063266?pr=3588

[quiet-node]

@mdqst any update?