feat: Effective healing and absorptions

[Sundava]

A bit hacking for my taste, but it works.

I've tried to avoid recalculating rhealing_effective and rabsorb_healing for each row, so it's calculated once on each update instead.

As always, only FR and EN are properly localized.

For #191

I haven't tested it in-game yet, I'd hold until merging (I'm not sure how it will work with partially absorbed shields)

[Sundava]

It is functional, even though the Absorbed Healing column includes overshields.
I'm not really happy about that, but I suspect it's a FFXIV ACT Plugin issue and not something I can fix on my end
(Appart from parsing each log line, but that would basically be reimplementing FFLogs of ACT_Plugin)

I'm marking this a ready for review/merge, and I'll try to account for overshielding if I find a solution later

[hibiyasleep]

IMO actually, the term 'effective healing' should not be a main metric to compare between healers within party. I'm not saying including absorbs & shields is bad, but excluding overheals are.

Let's imagine a full party with WHM & AST that both healers are never talked & both doing almost max effort they can normally do.
On next raidwide AoE, someone needed to heal this or we all gonna die. WHM prepares Plenary Indulgence + Afflatus Rapture both has no casting, AST prepares Stellar Explosion + Horoscope Helios also almost instant both are.
So the AoE came, that two healers activates their skills in same time. who achieved lower Overheals, who made more Effective Heals? if WHM's 100ms faster, can we blame AST as 'they did nothing'? no.
(I made WHM & AST as example as they're what I main, but if we think of SGE, my friends are shouting 'I should do a heal to fill my MP', despite I can't know their truth as I never been SGE.)

Overheal is the problem of Negotiation in most cases, it doesn't mean they're underskilled.
and as Effective Healing excludes Overheal completely, so we need to think more on this topic.

ps: Ikegami already adds their shield on their gauge in naïve and implictly.

[Sundava]

I believe the overhealing generated for this kind of specific moments would even out over the course of a fight, but I haven't healed in raids so I might be wrong.

I agree that overhealing is a normal part of healing, and you can't compare healers based this metric. Likewise,hps alone is not a good indicator of healer performance.
I think it's up to the user to understand and combine several metrics to evaluate performance (And in that case, more available metrics is better).
Plus, we already provide the overhealing %, so it's just a quick math for the user to calculate effective healing himself.

I wouldn't add it to the default columns, but I don't see the harm in having them available if someone wants them.

[hibiyasleep]

Providing effective/absorbed value is absolutely does not matter, and it should be, but using it as single main metric (so removing instead of adding overheal) would be problematic as it hides before decision.

Actual solution should be create 'unified healing gauge' as like other overlays do, but this is quite a headache for current codebase...

We would just add this for now & replace with this somewhen soon as possible.

[hibiyasleep]

'calculateMax' exists for preventing render functions from require whole encounter data. if there's additional column which requires whole encounter access, please move into Data.get().

[Sundava]

Just to clarify, you mean I should calculate that value in Data.get() and and store it directly in the player object ?

[hibiyasleep]

yes, I would prefer that way, but it's ok to keep if current approach is better (sorry, i'm confused of my old current codebase)