Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop active tasks before server shutdown #878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kanzihuang
Copy link
Contributor

No description provided.

@kanzihuang kanzihuang force-pushed the fix/stop-tasks-before-shutdown branch 2 times, most recently from 9beba9b to cc2d5d6 Compare May 5, 2024 00:12
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.73%. Comparing base (8df0bfa) to head (cc2d5d6).
Report is 4 commits behind head on master.

Current head cc2d5d6 differs from pull request most recent head 86c772f

Please upload reports for the commit 86c772f to get more accurate results.

Files Patch % Lines
processor.go 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   68.41%   68.73%   +0.31%     
==========================================
  Files          27       28       +1     
  Lines        3841     3857      +16     
==========================================
+ Hits         2628     2651      +23     
+ Misses        929      919      -10     
- Partials      284      287       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanzihuang kanzihuang force-pushed the fix/stop-tasks-before-shutdown branch from 2996705 to 86c772f Compare May 22, 2024 08:26
@kamikazechaser
Copy link
Collaborator

@kanzihuang The shutdownTimeout will always re-queue jobs that did not complete before it quits. This PR changes behavior in that running tasks are stopped and requeued for next time without allowing the jobs to complete.

	// ShutdownTimeout specifies the duration to wait to let workers finish their tasks
	// before forcing them to abort when stopping the server.
	//
	// If unset or zero, default timeout of 8 seconds is used.

@kamikazechaser kamikazechaser added the pr-alternative-available There is a workaround this issue with minimal work label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-alternative-available There is a workaround this issue with minimal work pr-feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants