HHH-19846 Drop JUnit 4 usage #11113
Open
HHH-19846 Drop JUnit 4 usage #11113
+5,961
−5,816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/entity/Java5FeaturesTest.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/entity/Java5FeaturesTest.java
Fixed
Show fixed
Hide fixed
dreab8
force-pushed
the
HHH-19846
branch
2 times, most recently
from
45025a8 to
239c0d9
Compare
...src/test/java/org/hibernate/orm/test/annotations/enumerated/mapkey/MapKeyEnumeratedTest.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/manytomany/Employer.java
Dismissed
Show dismissed
Hide dismissed
...c/test/java/org/hibernate/orm/test/annotations/onetoone/OneToOneJoinTableUniquenessTest.java
Dismissed
Show dismissed
Hide dismissed
| assertThat( tableA != null && tableB != null ) | ||
| .describedAs( "Could not find the expected tables." ) | ||
| .isTrue(); | ||
| assertThat( tableA.getUniqueKeys().values().iterator().next().getName() ) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning test
| .describedAs( "Could not find the expected tables." ) | ||
| .isTrue(); | ||
| assertThat( tableA.getUniqueKeys().values().iterator().next().getName() ) | ||
| .isNotEqualTo( tableB.getUniqueKeys().values().iterator().next().getName() ); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning test
Comment on lines
+37
to
+53
| PersonAddress _personAddress = scope.fromTransaction( entityManager -> { | ||
| Person person1 = new Person( "ABC-123" ); | ||
| Person person2 = new Person( "DEF-456" ); | ||
|
|
||
| Address address1 = new Address("12th Avenue", "12A", "4005A"); | ||
| Address address2 = new Address("18th Avenue", "18B", "4007B"); | ||
| Address address1 = new Address( "12th Avenue", "12A", "4005A" ); | ||
| Address address2 = new Address( "18th Avenue", "18B", "4007B" ); | ||
|
|
||
| entityManager.persist(person1); | ||
| entityManager.persist(person2); | ||
| entityManager.persist( person1 ); | ||
| entityManager.persist( person2 ); | ||
|
|
||
| entityManager.persist(address1); | ||
| entityManager.persist(address2); | ||
| entityManager.persist( address1 ); | ||
| entityManager.persist( address2 ); | ||
|
|
||
| PersonAddress personAddress = new PersonAddress(person1, address1); | ||
| entityManager.persist(personAddress); | ||
| PersonAddress personAddress = new PersonAddress( person1, address1 ); | ||
| entityManager.persist( personAddress ); | ||
| return personAddress; | ||
| }); | ||
| } ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped Junit4 in packages:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19846