Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JReinhold
Copy link
Contributor

I've added typings for TypeScript.

They should be pretty self explanatory, but feel free to ask questions if not.
They've been tested with our own project that uses this addon with TypeScript. Both exports require a url parameter/prop, and don't allow anything else.

@hharnisc
Copy link
Owner

Hey @JReinhold! I've not played around with TS too much yet, and was wondering if you tried this on JS project too? I'm guessing JS projects will just ignore this file, but wanted to be sure. Would you be up for sharing the project that you've added this too? Would be awesome to see how you're using the Figma addon.

@JReinhold
Copy link
Contributor Author

Our experiences are that JS just ignores the TS declarations completely, however I actually haven't tested it with this project to be honest. If you want to try it out with JS you can just download the index.d.ts and put in your node_modules/storybook-addon-figma folder at see that it should work perfectly.

I would LOVE to share our current project, however it is one of those internal super duper top secret confidential projects that I unfortunately can't share with anyone.
But I'm pretty sure we're gonna use this addon moving forward because it fits perfectly with our workflow, so when we end up working on a less secret project, I'll remember to share it here. 🙂

Let me know if you need anything else, we are really pleased with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants