Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

August 2024 updated apple logo🛟 #512

Closed

Conversation

nataliakeniganti
Copy link
Contributor

@nataliakeniganti nataliakeniganti commented Aug 30, 2024

Updated brand-emoji for the apple logo.
The original looks like this:
image

@nataliakeniganti nataliakeniganti changed the title August 2024 Updated Apple Logo🛟 August 2024 updated apple logo🛟 Aug 30, 2024
@nataliakeniganti
Copy link
Contributor Author

nataliakeniganti commented Sep 2, 2024

@b-g closed and merged pull request, accepted?

@nataliakeniganti nataliakeniganti deleted the august-2024 branch September 2, 2024 13:42
@nataliakeniganti nataliakeniganti restored the august-2024 branch September 2, 2024 13:44
@b-g
Copy link
Member

b-g commented Oct 1, 2024

Hi @nataliakeniganti, many thanks for this! We are back from the break. Happy to merge this ... but as an alternative. Please provide a new PR not touching the existing Apple logo and move the black one to hexcode E06E. Also there seems to be a small glitch, please fix as well. Happy to merge after. Cheers 👍
Screen Shot 2024-10-01 at 16 03 54

@b-g b-g closed this Oct 1, 2024
@b-g b-g mentioned this pull request Oct 1, 2024
@nataliakeniganti
Copy link
Contributor Author

@b-g may be ask unclosed?

@nataliakeniganti
Copy link
Contributor Author

Hi @nataliakeniganti, many thanks for this! We are back from the break. Happy to merge this ... but as an alternative. Please provide a new PR not touching the existing Apple logo and move the black one to hexcode E06E. Also there seems to be a small glitch, please fix as well. Happy to merge after. Cheers 👍 Screen Shot 2024-10-01 at 16 03 54

Fixed it
F8FF

nataliakeniganti added a commit to nataliakeniganti/openmoji that referenced this pull request Oct 1, 2024
Many thanks for this! We are back from the break. Happy to merge this ... but as an alternative. Please provide a new PR not touching the existing Apple logo and move the black one to hexcode E06E. Also there seems to be a small glitch, please fix as well. Happy to merge after. Cheers 👍 hfg-gmuend#512
@b-g
Copy link
Member

b-g commented Oct 2, 2024

Nope. Still glitchy. I closed the PR as I would prefer a new one without all the noise. I hope you don't mind.

PS. Heads up: Will be working in the next days on all constantly as I have a limited time window. If you plan to contribute, please pull frequently and be aware that a few things might have become obsolete in PR as already addressed.

Screen Shot 2024-10-02 at 08 13 47

@nataliakeniganti
Copy link
Contributor Author

nataliakeniganti commented Oct 2, 2024

Nope. Still glitchy. I closed the PR as I would prefer a new one without all the noise. I hope you don't mind.

PS. Heads up: Will be working in the next days on all constantly as I have a limited time window. If you plan to contribute, please pull frequently and be aware that a few things might have become obsolete in PR as already addressed.

Screen Shot 2024-10-02 at 08 13 47

Removed more glitches
F8FF

nataliakeniganti added a commit to nataliakeniganti/openmoji that referenced this pull request Oct 2, 2024
Nope. Still glitchy. I closed the PR as I would prefer a new one without all the noise. I hope you don't mind.

PS. Heads up: Will be working in the next days on all constantly as I have a limited time window. If you plan to contribute, please pull frequently and be aware that a few things might have become obsolete in PR as already addressed. hfg-gmuend#512
@b-g
Copy link
Member

b-g commented Oct 3, 2024

Thanks. Looks better without the glitches. I've tested the file ... please use https://openmoji-tester.glitch.me/ ... quite some red lights. Won't be able to merge this without having the nitty gritty details right. Sorry!

@nataliakeniganti
Copy link
Contributor Author

Thanks. Looks better without the glitches. I've tested the file ... please use https://openmoji-tester.glitch.me/ ... quite some red lights. Won't be able to merge this without having the nitty gritty details right. Sorry!

btw removed glitches

@b-g
Copy link
Member

b-g commented Oct 9, 2024

Let know once the logo is fixed and passed the tests. Happy to add it then to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants