Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide communities from top collected #344

Closed
wants to merge 2 commits into from
Closed

feat: hide communities from top collected #344

wants to merge 2 commits into from

Conversation

andriishupta
Copy link
Contributor

@andriishupta andriishupta commented Aug 9, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

  • add query sources for TOP_COLLECTED
  • add lensterCommunity app to keep reference that it exists
  • add .gitignore for .idea
  • fix startup issue with mixpanel.ts

Closes #36

- add query sources for TOP_COLLECTED
- add `lensterCommunity` app to keep reference that it exists
- add .gitignore for .idea
- fix startup issue with mixpanel.ts
@vercel
Copy link

vercel bot commented Aug 9, 2022

@andriishupta is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

@andriishupta
Copy link
Contributor Author

andriishupta commented Aug 9, 2022

followed API to query by every existing app that Lenster supports, except for "lenster community"
https://docs.lens.xyz/docs/explore-publications#request

@andriishupta andriishupta marked this pull request as ready for review August 9, 2022 12:20
@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 0:23AM (UTC)

@vercel vercel bot temporarily deployed to Preview August 9, 2022 12:23 Inactive
data/apps.ts Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@andriishupta
Copy link
Contributor Author

@bigint, I have seen that you merged the main branch - I prefer to rebase and force-push in feature branches so that I will squash my commits and will force push new single commit when there would be new changes

why would I or some other contributor pollute git history with 10+ commits like "fix lint", "fix typo", etc.

@bigint
Copy link
Member

bigint commented Aug 9, 2022

Yup I did rebase in GitHub UI 🙇🏼

We always do squash merge PRs 🤗

Also I'm going ahead and closing this PR because we don't want to filter with the apps only we specified 🙏🏼

As said this is blocked on backend, when we get unblocked we can visit this issue back 🙏🏼

@bigint bigint closed this Aug 9, 2022
@andriishupta andriishupta deleted the feat/36-Hide_communities_from_top_collected branch August 9, 2022 14:45
@andriishupta
Copy link
Contributor Author

@bigint cool ;)

good that I have checked the codebase and now have an overall understanding of how it is built :)

I checked also other issues today - for some reason, Post collection didn't work on Mainnet, so I cannot check issue #66 - "transaction was indexing" for 15min and I just closed the modal.
Others don't have descriptions yet, and I expect them to be bigger, so I could take them when you would add some details

And again, if you know the "implementation plan" or you know that it is blocked by BE - please, let me know

It was fun to do this PR today 😅

Thanks!

@bigint
Copy link
Member

bigint commented Aug 9, 2022

Again #66 is blocked by Lens backend 😭

I'd suggest you to DM me on Discord 💌 https://lenster.xyz/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Hide communities from top collected
2 participants