Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract GHA From #37 #39

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Extract GHA From #37 #39

merged 5 commits into from
Sep 19, 2023

Conversation

hexylena
Copy link
Owner

We clearly needed this sooner.

I am morally opposed to isort linting, if there is something that will automatically apply the isort, then awesome, let's add it to the reformat make target, but the linting without an automatic fix I object to.

@hexylena
Copy link
Owner Author

@bernt-matthias look ok to you?

@hexylena hexylena merged commit 9281659 into master Sep 19, 2023
0 of 2 checks passed
@hexylena
Copy link
Owner Author

Merged despite failing, will fix that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernt-matthias bernt-matthias bernt-matthias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hexylena @bernt-matthias