-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: no-useless-concat & one-var (uninitialized) #3717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we merge this PR, we should discuss use the prettier or not. As you know active maintainers discussed this matter hexojs/eslint-config-hexo#7 PS: I agree to use prettier |
Even without prettier, for consistency, we shouldn't override eslint-config-hexo in the first place. |
tomap
previously approved these changes
Oct 17, 2019
curbengh
force-pushed
the
no-useless-concat
branch
from
October 17, 2019 06:44
155eba7
to
bf4ab1e
Compare
Rebased |
curbengh
force-pushed
the
no-useless-concat
branch
from
October 19, 2019 00:20
933851b
to
3eba1fe
Compare
curbengh
force-pushed
the
no-useless-concat
branch
from
October 28, 2019 09:51
3eba1fe
to
e690eca
Compare
Ready for review. |
@hexojs/core |
SukkaW
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
no-useless-concat
somehow is not enforced in recent commits.I also remove rules override in
.eslintrc.json
for consistency across hexo projects.Removing rules override is also in preparation for prettier to avoid conflicting rules (e.g. [1], [2]).
How to test
Pull request tasks