Draft: Refactoring code to be more modular #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added static Typing, unit tests for ros_helpers and graph_nav_util, refactored spot_wrapper.py into separate modules, added Github Actions CI pipeline, tested on Spot 3.2.0 and ROS Noetic
* added static Typing, unit tests for ros_helpers and graph_nav_util, refactored spot_wrapper.py into separate modules, added Github Actions CI pipeline, tested on Spot 3.2.0 and ROS Noetic
* added ROS unit testing of publishers, services, action servers
* Added spot_check ROS service --------- Co-authored-by: Ming Jie See <>
* publish pointcloud from VLP16 * add unit tests --------- Co-authored-by: Yoshiki Obinata <[email protected]> Co-authored-by: Michal Staniaszek <[email protected]>
… sync-with-upstream
Sync with upstream
… feature/pick-service
Add pick service
* add docker_export Github action
… sync-with-upstream
Sync with upstream, add unit tests for Dock ROS action
|
Wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #104, this updates the code to the refactored Spot Wrapper in bdaiinstitute/spot_wrapper#6
WIP.