Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use generic request for remaining get calls #625

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Mar 17, 2025

  • Also split the metrics query parameter building into a Validate() error and a values() url.Values functions.

@jooola jooola requested a review from a team as a code owner March 17, 2025 08:39
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (fc99d70) to head (0dc6c29).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/load_balancer.go 95.00% 1 Missing ⚠️
hcloud/server.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   70.95%   70.90%   -0.06%     
==========================================
  Files          49       49              
  Lines        4431     4416      -15     
==========================================
- Hits         3144     3131      -13     
+ Misses        955      954       -1     
+ Partials      332      331       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola merged commit 88352df into main Mar 17, 2025
5 checks passed
@jooola jooola deleted the generic-get branch March 17, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants