Skip to content

feat(node): make the zone label configurable - #1311

Open
lukasmetzner wants to merge 2 commits into
mainfrom
feat/disable-zone-label-creation
Open

feat(node): make the zone label configurable#1311
lukasmetzner wants to merge 2 commits into
mainfrom
feat/disable-zone-label-creation

Conversation

@lukasmetzner

@lukasmetzner lukasmetzner commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Adds HCLOUD_INSTANCES_ZONE_LABEL_ENABLED (default true), which controls
whether topology.kubernetes.io/zone / failure-domain.beta.kubernetes.io/zone
are set on Cloud Server nodes during initialization.

The default stays true: topology labels are only applied at node
initialization, so disabling this on a running cluster leaves a mix of labeled
and unlabeled nodes. docs/guides/zone-label.md covers the migration and how
to check whether anything selects on the label. We can remove this feature and
the label in the next major version.

Robot servers are unaffected and keep their datacenter zone label.

Closes #1146

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.25%. Comparing base (926a08a) to head (59c0813).

Files with missing lines Patch % Lines
internal/config/config.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   71.85%   71.25%   -0.61%     
==========================================
  Files          27       27              
  Lines        2800     2804       +4     
==========================================
- Hits         2012     1998      -14     
- Misses        613      622       +9     
- Partials      175      184       +9     
Flag Coverage Δ
e2e 44.73% <71.42%> (+<0.01%) ⬆️
unit 67.61% <71.42%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmetzner
lukasmetzner force-pushed the feat/disable-zone-label-creation branch from 4cc133a to deb8229 Compare August 3, 2026 14:36
@lukasmetzner lukasmetzner changed the title feat(node): disable zone label for cloud servers feat(node): make the zone label configurable Aug 6, 2026
@lukasmetzner
lukasmetzner force-pushed the feat/disable-zone-label-creation branch from deb8229 to 59c0813 Compare August 6, 2026 08:01
@lukasmetzner
lukasmetzner marked this pull request as ready for review August 6, 2026 08:34
@lukasmetzner
lukasmetzner requested a review from a team as a code owner August 6, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phasing out Datacenters in favor of Locations

1 participant