feat(node): make the zone label configurable - #1311
Open
lukasmetzner wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
- Coverage 71.85% 71.25% -0.61%
==========================================
Files 27 27
Lines 2800 2804 +4
==========================================
- Hits 2012 1998 -14
- Misses 613 622 +9
- Partials 175 184 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lukasmetzner
force-pushed
the
feat/disable-zone-label-creation
branch
from
August 3, 2026 14:36
4cc133a to
deb8229
Compare
lukasmetzner
force-pushed
the
feat/disable-zone-label-creation
branch
from
August 6, 2026 08:01
deb8229 to
59c0813
Compare
lukasmetzner
marked this pull request as ready for review
August 6, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
HCLOUD_INSTANCES_ZONE_LABEL_ENABLED(defaulttrue), which controlswhether
topology.kubernetes.io/zone/failure-domain.beta.kubernetes.io/zoneare set on Cloud Server nodes during initialization.
The default stays
true: topology labels are only applied at nodeinitialization, so disabling this on a running cluster leaves a mix of labeled
and unlabeled nodes.
docs/guides/zone-label.mdcovers the migration and howto check whether anything selects on the label. We can remove this feature and
the label in the next major version.
Robot servers are unaffected and keep their datacenter zone label.
Closes #1146