fix: get error resolver when user uses different nacos in few seconds #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jin-gou
requested changes
Jan 26, 2024
nacos/v2/resolver.go
Outdated
| group: "DEFAULT_GROUP", | ||
| cluster: "DEFAULT", | ||
| group: "DEFAULT_GROUP", | ||
| timestamp: time.Now().String(), |
There was a problem hiding this comment.
直接使用时间戳构造唯一 key，在业务滥用 resolver 初始化时会在存在 goroutine 的泄露的问题，需要根据业务场景具体情况具体看了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it (English/Chinese):
在之前的 Name() 实现中return 的是一个常量, 在使用不同配置的 nacos 的默认情况下
uniqueKey := cacheKey(config.Resolver.Name(), config.Balancer.Name(), config.LbOpts)会在短时间取到相同的结果
于是现在添加 timestamp 作为唯一标识, 防止出现取到错误数据
Which issue(s) this PR fixes:
#107