Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename wrapper to tab wrapper #4636

Merged
merged 5 commits into from
Jan 30, 2025
Merged

fix: rename wrapper to tab wrapper #4636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3249a52
fix: rename wrapper to tab wrapper
winchesHe Jan 24, 2025
5171be3
docs: update
winchesHe Jan 24, 2025
0e58930
docs: update
winchesHe Jan 27, 2025
20955f3
docs: update
winchesHe Jan 27, 2025
6ec9d40
fix: rename wrapper to tab wrapper
winchesHe Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-ladybugs-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@heroui/theme": patch
---
wingkwong marked this conversation as resolved.
Show resolved Hide resolved

Fix tabs slots "wrapper" rename to "tabWrapper" -- Breaking Change (#4552)
3 changes: 2 additions & 1 deletion apps/docs/content/docs/components/tabs.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ function AppTabs() {
- **tabContent**: The tab content slot, it wraps the tab content.
- **cursor**: The cursor slot, it wraps the cursor. This is only visible when `disableAnimation=false`
- **panel**: The panel slot, it wraps the tab panel (content).
- **tabWrapper**: The tab wrapper slot, it wraps the tab and the tab content.

### Custom Styles

Expand Down Expand Up @@ -343,7 +344,7 @@ You can customize the `Tabs` component by passing custom Tailwind CSS classes to
},
{
attribute: "classNames",
type: "Partial<Record<\"base\"｜ \"tabList\"｜ \"tab\"｜ \"tabContent\"｜ \"cursor\" ｜ \"panel\", string>>",
type: "Partial<Record<\"base\"｜ \"tabList\"｜ \"tab\"｜ \"tabContent\"｜ \"cursor\" ｜ \"panel\" ｜ \"tabWrapper\", string>>",
description: "Allows to set custom class names for the card slots.",
default: "-"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/tabs/src/use-tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export function useTabs<T extends object>(originalProps: UseTabsProps<T>) {
const getWrapperProps: PropGetter = useCallback(
(props) => ({
"data-slot": "tabWrapper",
className: slots.wrapper({class: clsx(classNames?.wrapper, props?.className)}),
className: slots.tabWrapper({class: clsx(classNames?.tabWrapper, props?.className)}),
"data-placement": placement,
"data-vertical":
isVertical || placement === "start" || placement === "end" ? "vertical" : "horizontal",
Expand Down
8 changes: 4 additions & 4 deletions packages/core/theme/src/components/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const tabs = tv({
// focus ring
...dataFocusVisibleClasses,
],
wrapper: [],
tabWrapper: [],
},
variants: {
variant: {
Expand Down Expand Up @@ -166,15 +166,15 @@ const tabs = tv({
start: {
tabList: "flex-col",
panel: "py-0 px-3",
wrapper: "flex",
tabWrapper: "flex",
},
end: {
tabList: "flex-col",
panel: "py-0 px-3",
wrapper: "flex flex-row-reverse",
tabWrapper: "flex flex-row-reverse",
},
bottom: {
wrapper: "flex flex-col-reverse",
tabWrapper: "flex flex-col-reverse",
},
},
},
Expand Down