Make Vegur's dynamic config relup-safe #179
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading a release through a relup, the SASL release_handler
process goes through the application's config, and resets all of those
of currently running applications. The new value is based off, in order:
All the values that were added and changed dynamically are dropped.
This changeset forces a separation between dynamic and static
configuration values. Static configuration values are set in the
'vegur' app and can be changed by sys.config and others. Dynamic
configuration values are set in the 'vegur_dynamic' app name -- since no
such app exists, they are safely ignored by SASL.
To keep the change backwards compatible for all usages, this patch
therefore makes a two-tiered config lookup:
somewhere and is therefore important)
(per version) default to use.
This may come at a slight performance hit (two lookups instead of one)
for some static values, but this has never been a bottleneck compared to
say, CamelCasing headers, and without this change, no live code upgrades
with relups can be performed in a system relying on vegur.