Bring back #disable! support
#15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of [#7](#7) we lost the ability to totally disable the logger, across all threads. It's unclear if this was intentional, but I am guessing it was not. This will restore the behavior by returning a new `NullOutput` instance when trying to write while disabled. This might cause A LOT of object allocations, all with short lives. Hopefully. If so, we could consider some form of memoization of the instance.
stevenharman
force-pushed
the
disable_support
branch
from
557822d
to
db917e9
Compare
|
I'd like to get this merged. Turns out addons.h.c depends on disable! |
|
I'm not 💯 sure this implementation works as intended (i.e., can you re-enable in the block form if If you need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #7 we lost the ability to totally disable the logger, across all threads. It's unclear if this was intentional, but I am guessing it was not. This will restore the behavior by returning a new
NullOutputinstance when trying to write while disabled. This might cause A LOT of object allocations, all with short lives. Hopefully. If so, we could consider some form of memoization of the instance.Alternatively, we might choose that we don't actually want this feature. In which case we need to update the
READMEand probably mention it in theCHANGELOG.NOTE: This PR also introduces a
#enable!, which would close #4.Thoughts?