Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async/await for withCluster #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

async/await for withCluster #166

wants to merge 2 commits into from

Conversation

jdx
Copy link
Contributor

@jdx jdx commented Jun 1, 2017 •
edited
Loading

No description provided.

@idan idan added the Doing label Jun 1, 2017
@jdx jdx changed the title standard 10 async/await for withCluster Jun 1, 2017
@jdx jdx requested a review from msakrejda June 1, 2017 13:23
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 88.742% when pulling 132ae72 on async-await into 04dee65 on master.

@msakrejda
Copy link
Contributor

Oh my God yes. Let's get #165 sorted out first, but this is great.

Here's a whitespace-ignoring diff for easier review: https://github.com/heroku/heroku-kafka-jsplugin/pull/166/files?w=1

@jdx
Copy link
Contributor Author

jdx commented Jul 6, 2017

@uhoh-itsmaciek this is ready again

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 89.037% when pulling a7f7019 on async-await into ba2d4b3 on master.

@idan idan added Backlog and removed Doing labels Jul 11, 2017
@idan
Copy link
Contributor

idan commented Aug 29, 2017

Deferred for now.

@idan idan removed the Backlog label Aug 29, 2017
@valeriecodes valeriecodes changed the base branch from master to main August 10, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msakrejda msakrejda Awaiting requested review from msakrejda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdx @coveralls @msakrejda @idan