-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default Ruby version to 3.3.7 #1534
Draft
schneems
wants to merge
7
commits into
main
Choose a base branch
from
schneems/default-ruby-336
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/default-ruby-336
branch
2 times, most recently
from
January 6, 2025 15:59
bc8afc7
to
8ca07fc
Compare
The latest Ruby is now 3.4.x. Our ideal default policy is to use the latest release of the prior year's version. This PR updates to the latest Ruby 3.3.x version which is 3.3.6.
@schneems could now default to 3.3.7 https://www.ruby-lang.org/en/news/2025/01/15/ruby-3-3-7-released/ |
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
January 21, 2025 21:02
8ca07fc
to
9848194
Compare
schneems
changed the title
Update default Ruby version to 3.3.6
Update default Ruby version to 3.3.7
Jan 21, 2025
Fixes: ``` -----> Building on the Heroku-24 stack -----> Fetching https://github.com/heroku/heroku-buildpack-ruby#schneems/default-ruby-336 buildpack... buildpack downloaded -----> Ruby app detected ! ! undefined method `exists?' for class Dir ! /tmp/buildpacks/55030ecaa578151bf5924184e8750b99212faef5/lib/language_pack/helpers/bundler_wrapper.rb:242:in `fetch_bundler': undefined method `exists?' for class Dir (NoMethodError) return true if Dir.exists?(bundler_path) ^^^^^^^^ Did you mean? exist? ```
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
January 27, 2025 23:14
72886a1
to
43f05b6
Compare
Bundler 1.x is not able to run with Ruby 3.3 in some circumstances: ``` remote: ! There was an error parsing your Gemfile, we cannot continue remote: ! /tmp/d20250127-138-l8vq2r/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:29:in `root': undefined method `untaint' for an instance of Pathname (NoMethodError) remote: ! remote: ! Pathname.new(gemfile).untaint.expand_path.parent ``` This commit updates the default bundler version to 2.3.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Ruby is now 3.4.x. Our ideal default policy is to use the latest release of the prior year's version. This PR updates to the latest Ruby 3.3.x version which is 3.3.7.