Python 3.12 compatibility for build tooling #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
May 22, 2024
edmorley
reviewed
May 22, 2024
dzuelke
force-pushed
the
python312-compat
branch
2 times, most recently
from
62eb973
to
66e5979
Compare
Ubuntu 24.04 no longer allows a "direct" install of pip packages without a virtual environment, so in preparation for that, we're now setting up a venv. GUS-W-15794852
We use the natsort PyPI package now - distutils.versions is deprecated in Python 3.12, which Ubuntu 24.04 ships with. GUS-W-15794852
Not passing timezones explicitly is deprecated in Python 3.12, which Ubuntu 24.04 ships with. GUS-W-15794852
Not passing timezones explicitly is deprecated in Python 3.12, which Ubuntu 24.04 ships with. GUS-W-15794852
We are upgrading to bob-builder 0.0.20, which will be able to use the S3_REGION env var, but it needs a "correct" value, like "us-east-1". GUS-W-15794852
It now uses boto3, which, unlike the old boto, works with Python 3.12 or newer, and that's what Ubuntu 24.04 ships with. GUS-W-15794852
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 24.04 ships with Python 3.12, which deprecates a few things we use (
distutils.version,datetime.datetime.utc*).More crucially, bob-builder uses
boto, which due to a weird vendoring ofsixis incompatible with Python 3.12, so we need to update it to 0.0.20, which usesboto3.That version picks up
S3_REGIONfrom the environment, but ourS3_REGIONvalues so far contained a prefix of "s3.".GUS-W-15794852