2023-09 housekeeping #656
Merged
2023-09 housekeeping #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Sep 28, 2023
dzuelke
force-pushed
the
2023-09-housekeeping
branch
3 times, most recently
from
29d0e83
to
6e1a3fe
Compare
|
Updated |
New Focal based instances spawn bash in a way that does not allow the installation of SIGPIPE handlers. But waitforit.sh needs SIGPIPE to detect when a test finishes. The workaround is to now manually issue a different signal when the write to a popeline fails. This would cause certain tests to hang forever. Put some comments in to better explain how the whole thing works. GUS-W-14213860
Fix has landed :) This reverts commit 86df1f8.
Closes #655
dzuelke
force-pushed
the
2023-09-housekeeping
branch
from
dbff3ee
to
1c5fac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop 86df1f8 since it was fixed by heroku/cli#2467.
Update a few dependencies for Bundler and Composer, all together (and have dependabot group these in the future).