Repository navigation
refactor: use @heroku/sdk for sessions commands - #4090
Merged
Merged
Conversation
sbosio
reviewed
Nov 20, 2026
sbosio
approved these changes
Nov 20, 2026
sbosio
left a comment
Contributor
There was a problem hiding this comment.
Great work. I left one single comment, but it's more of a question, non-blocking.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the
sessions:indexandsessions:destroycommands to@heroku/sdk.@heroku/sdkresource methods (platform.oauthSession.*)src/lib/sessions/sessions.ts— the localOAuthSessioninterface it exported is no longer needed now that the SDK's ownoauthSessionresource types are used.HerokuSDK.prototype.platforminstead of intercepting HTTP withnock.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Setup:
npm i && npm run buildSteps:
./bin/run sessions— verify your OAuth sessions list, sorted alphabetically by description, orNo OAuth sessions../bin/run sessions— identify the new browser session's ID./bin/run sessions:destroy <browser-id>— verify the spinner displays./bin/run sessions— verify the session is destroyed and removedScreenshots (if applicable)
Related Issues
GUS work item: W-23387756