[stacked] Finalize bullet_stream output update #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the task name is so long you can't see which guide is being executed without clicking through. This PR refactors the task so that the name is shorter (by making the task name shorter and removing arch variables from the matrix.
Uses the newly defined `output` interface that Manuel introduced for the JVM buildpack in #745 instead of the legacy libherokubuildpack::log::log_error. For all buildpacks except for jvm-function-invoker.
The trailing whitespace after the `! ` shouldn't be significant.
schneems
changed the title
The `track_timing` interface (from the name alone) isn't clear that it produces a sub-bullet output (it wasn't actually clear that it didn't produce dots `.....`). There are places where it's used incorrectly: ``` - Running `./mvnw dependency:list` quietly - Done (7.6s) ``` This change makes it harder to use wrong. Every streamed command has timing information emitted, guaranteed, so there's never a mistake of output from one command bleeding into another by accident.
This doesn't use the bullet_stream "dots" feature (which I don't think is implemented here) but it does emit the timing information on the next line to indicate that it finished.
``` - Done (4.4s) Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 - Done (finished in 34.0s) ```
schneems
added
the
skip changelog
schneems
force-pushed
the
schneems/bs_output_ready_for_review
branch
from
d34f43c to
f02864f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carries #745 over the line so the new output format can be merged. As opposed to #767 this is intended to be a minimal change. It does not resolve #762. It does not update the
jvm-function-invokerbuildpack's output.Commits are targeted and intended to be reviewed individually, in order.