-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Bullet stream output style + additional output + error updates #327
Draft
schneems
wants to merge
49
commits into
main
Choose a base branch
from
schneems/bs_diff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shows the path where the error occurred.
This eliminates a problem I was seeing when upgrading dependencies on one but not both Cargo.toml files where there's a type mis-match.
On cache restore it needs to increment the cache key
Also switched to using try_exist to raise FS errors when detecting files.
This branch allows using the derive functionality for 1 or more attributes and diffing the rest with a custom function.
This prevents accidentally serializing more data into a struct with fewer fields. By default a struct with `name: String, job: String` can serialize into a struct with only one of those values i.e. `name: String`. With this setting, an error will be raised instead.
schneems
force-pushed
the
schneems/bs_diff
branch
from
January 27, 2025 20:02
e60abf9
to
623d8b6
Compare
schneems
force-pushed
the
schneems/bs_diff
branch
from
January 30, 2025 23:39
2e70fa6
to
96fd476
Compare
schneems
force-pushed
the
schneems/bs_diff
branch
from
January 30, 2025 23:40
96fd476
to
a31801e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is my maximal take on build output which extends to the way that layers emit cache information, and errors are captured and emitted. It is intended to be a fully functioning and working change to update to the
bullet_stream
style. This work can be used to compare-and-contrast an additional information if the Go owner believes that's the best way forward. It is also intended to be fully functional and mergable (if desired).Changes
deny_unknown_fields
fs_err
so the name of the file is included in the error messageCommits are relatively small and can roughly be reviewed in order if you're interested in merging this. Otherwise you're welcome to use it as a reference or starting place for how to do the work.
Todo:
cache_diff
crate to a released version after Addcustom = <function>
container attribute and allow optionalignore = "<reason>"
for fields heroku-buildpacks/cache_diff#6 is merged.Out of scope: