Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Bullet stream output style + additional output + error updates #327

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

schneems
Copy link

@schneems schneems commented Jan 27, 2025

What

This PR is my maximal take on build output which extends to the way that layers emit cache information, and errors are captured and emitted. It is intended to be a fully functioning and working change to update to the bullet_stream style. This work can be used to compare-and-contrast an additional information if the Go owner believes that's the best way forward. It is also intended to be fully functional and mergable (if desired).

Changes

Commits are relatively small and can roughly be reviewed in order if you're interested in merging this. Otherwise you're welcome to use it as a reference or starting place for how to do the work.

Todo:

Out of scope:

  • Error wording and display audit

It shows the path where the error occurred.
This eliminates a problem I was seeing when upgrading dependencies on one but not both Cargo.toml files where there's a type mis-match.
On cache restore it needs to increment the cache key
Also switched to using try_exist to raise FS errors when detecting files.
This branch allows using the derive functionality for 1 or more attributes and diffing the rest with a custom function.
@schneems schneems requested review from joshwlewis and a team as code owners January 27, 2025 19:44
@schneems schneems marked this pull request as draft January 27, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant