Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ struct SExperiment {
std::string value;
// The labels associated with this experiment.
std::vector<std::string> labels;
// Experiment Phase name
std::string phase_name;
// Experiment Phase Variant name
std::string phase_variant_name;
};

// All experiments that this identity is involved with.
Expand Down
4 changes: 4 additions & 0 deletions satori-cpp/api/satori.proto
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,10 @@ message Experiment {
string value = 2;
// The labels associated with this experiment.
repeated string labels = 3;
// Experiment Phase name
string phase_name = 4;
// Experiment Phase Variant name
string phase_variant_name = 5;
}

// All experiments that this identity is involved with.
Expand Down
12 changes: 12 additions & 0 deletions satori-cpp/src/InternalLowLevelSatoriAPI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,18 @@ bool jsonValueToSExperiment(const rapidjson::Value& input, SExperiment& output)
output.labels.emplace_back(jsonLabel.GetString());
}
}
if (input.HasMember("phase_name")) {
if (!input["phase_name"].IsString()) {
return false;
}
output.phase_name = input["phase_name"].GetString();
}
if (input.HasMember("phase_variant_name")) {
if (!input["phase_variant_name"].IsString()) {
return false;
}
output.phase_variant_name = input["phase_variant_name"].GetString();
}
return true;
}

Expand Down
Loading