Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hermit): add stabilized interface #2

Closed
wants to merge 1 commit into from
Closed

feat(hermit): add stabilized interface #2

wants to merge 1 commit into from

Conversation

stlankes
Copy link

HermitOS is a unikernel and its interface to the kernel is provided by https://crates.io/crates/hermit-abi. In the meantime parts of the interface is stabilized and we want to integrated it into libc. Unstable version will be still provided by hermit-abi.

Thanks for considering submitting a PR!

We have the contribution guide. Please read it if you're new here!

Here's a checklist for things that will be checked during review or continuous integration.

  • Edit corresponding file(s) under libc-test/semver when you add/remove item(s), e.g. edit linux.txt if you add an item to src/unix/linux_like/linux/mod.rs
  • Your PR doesn't contain any private or unstable values like *LAST or *MAX (see #3131)
  • If your PR has a breaking change, please clarify it
  • If your PR increments version number, it must NOT contain any other changes (otherwise a release could be delayed)
  • Make sure ci/style.sh passes
  • cd libc-test && cargo test
    • (this might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure)

Delete this line and everything above before opening your PR.

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not get through all system calls yet, but I think we will have to rework some things before stabilization.

src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
src/hermit/mod.rs Outdated Show resolved Hide resolved
@stlankes stlankes force-pushed the hermit branch 3 times, most recently from 96b537c to 62940d2 Compare May 8, 2024 09:08
@mkroening mkroening self-requested a review May 8, 2024 09:20
@mkroening mkroening force-pushed the hermit branch 2 times, most recently from c7abc9a to 04e11a8 Compare May 13, 2024 15:39
@mkroening mkroening changed the title add stabilized interface to HermitOS feat(hermit): add stabilized interface May 14, 2024
@mkroening mkroening force-pushed the hermit branch 2 times, most recently from a1444ee to 0a73522 Compare May 14, 2024 11:59
@mkroening mkroening force-pushed the hermit branch 2 times, most recently from 7f7795f to d09cb1d Compare May 22, 2024 15:26
HermitOS is a unikernel and its interface to the kernel is provided
by https://crates.io/crates/hermit-abi. In the meantime parts of the
interface is stabilized and we want to integrated it into libc.
Unstable version will be still provided by hermit-abi.

Co-authored-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants