-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for identities to Impls #968
Open
varun10p
wants to merge
45
commits into
main
Choose a base branch
from
varun10p-identities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 33 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
eb0e70f
Added support for identities
varun10p 8adc504
Syntax checking back in the macro
c77537e
remove debug
6f61a0a
fixing cond
aa4576e
Fixing comments
varun10p dd71ba6
Moving fp-safe to impl
fd4079c
Continued
varun10p 643053e
Only comparators left
varun10p f5f47d0
Removed fp-safe rulesets
varun10p 3b7f1ad
Exp rules
varun10p f1d66d1
Adding rules back
varun10p a22241a
Cleanup rules
varun10p fef3e8c
Fixed up rules
varun10p da5bd20
Condense sets
varun10p ff472ae
More condensing
varun10p 477f2f5
Fixed some compilation
varun10p c016f83
typos
varun10p f747780
impl-infos
varun10p 336c5e7
typo
varun10p f0f738b
contract
varun10p 9e632dc
fmt
460027a
making dictionary
varun10p ba1f1ca
Remove expansive check
varun10p 69991e6
Fixing fmt
71aa259
Merge remote-tracking branch 'origin/main' into varun10p-identities
varun10p 8b310a1
Fixing merges
varun10p d905bda
Fixing contract
varun10p 505583c
fmt
430dc24
Additional fixes
9a69987
Impl names in identity
83fbca6
More impl names
534ba00
Added f32
b89be15
Found bug + fmt
a4efa40
Exact rules
3a50b18
Type-checking logic added
09c9ffc
Fixed bugs.
8027e3b
More fixes
65556e8
Found last bugs
fc1064b
Fpcore bug fix
e975732
Better fix
c2e5e39
Merge remote-tracking branch 'origin/main' into varun10p-identities
1c76a18
Last change + fmt
95bc0e1
Merge remote-tracking branch 'origin/main' into varun10p-identities
3bcc196
Fixing contract + fmt
dcd5694
Merge branch 'main' into varun10p-identities
varun10p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still strange. What is the story here?