refactor: migrate Android date picker from AlertDialog to DialogFragment #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace AlertDialog-based implementation with DialogFragment for better lifecycle management - Add proper fragment handling for activity configuration changes - Improve dialog dismissal logic with fragment manager cleanup - Maintain existing picker functionality and event handling
4 tasks
zhenkaGo
requested a deployment
to
e2e Android
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the crash that occurs on Samsung Android devices when the date picker is open during screen rotation.
The original implementation used a basic AlertDialog which doesn't properly handle activity lifecycle changes during configuration changes like screen rotation. Samsung devices appear to be more strict about dialog lifecycle management, causing crashes when the dialog tries to reference a destroyed activity context.
Fixes #913