-
-
Notifications
You must be signed in to change notification settings - Fork 376
Fix New Architecture support for latest React Native and Expo versions #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix New Architecture support for latest React Native and Expo versions #939
Conversation
- Add proper TurboModule protocol implementation - Include RNDatePickerSpecs.h for New Architecture builds - Implement required getConstants and getTurboModule methods - Add requiresMainQueueSetup method - Ensure compatibility with both Old and New Architecture using conditional compilation Fixes compatibility issues with React Native and Expo versions that have New Architecture enabled by default. Tested on React Native 0.79.6 and Expo 53.0.22.
On non-expo react-native 0.81.1, and date picker 5.0.13, this seems good. cheers |
This change is required for modern versions of Expo. Any chance of a merge? Pinning to the fork is less than idea. |
Seconding that! Would <3 to see this merged soon so we can unblock Expo 53 update |
I have tested this branch on react native 0.81.4(not using expo) and it appears to be working properly. |
I have tested this change with React Native 0.81.4 and Expo SDK 54. |
I've tested with the following versions: expo: 54.0.12 Project is able to build, and the component is also working on both iOS and Android. However on iOS, we're getting the following error: Error ReportModule provider RNDatePickerManager does not conform to RCTModuleProvider __37+[RCTModuleProviders moduleProviders]_block_invoke Project is fine after dismissing the error. |
react-native: 0.81.4 Confirming what @lishaan has stated. error appears on IOS only, android is fine |
yes, for now downgrading to 5.0.12 solves the problem |
Works fine for me ios 26 and 18.5- |
Problem
This package claimed to support React Native's New Architecture from version 4.3.0, but was missing proper TurboModule implementation for the latest React Native and Expo versions with New Architecture enabled by default.
Solution
RNDatePickerSpecs.h
for New Architecture buildsgetConstants
andgetTurboModule
methodsrequiresMainQueueSetup
methodTesting
Impact
Fixes crashes and compatibility issues for users running latest React Native and Expo versions.