Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove check if function exists in acf service. #1277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove check if function exists in acf service. #1277

wants to merge 1 commit into from

Conversation

sebastianthulin
Copy link
Member

@sebastianthulin sebastianthulin commented Jan 22, 2025 •
edited
Loading

This pull request includes a change to the getFieldKeysForGroup method in the FilterGetFieldToRetriveCommonValues.php file. The change simplifies the method by removing the conditional function call and directly using the acfGetFields method from the acfService.

Simplification of method:

@sebastianthulin sebastianthulin marked this pull request as ready for review January 22, 2025 12:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiclasNorin NiclasNorin NiclasNorin approved these changes

@thorbrink thorbrink thorbrink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianthulin @thorbrink @NiclasNorin