fix(repo): accept gzip-compressed index.yaml responses - #32483
Open
vigneshakaviki wants to merge 1 commit into
Open
fix(repo): accept gzip-compressed index.yaml responses#32483vigneshakaviki wants to merge 1 commit into
vigneshakaviki wants to merge 1 commit into
Conversation
Signed-off-by: vigneshakaviki <kumarvignesh295@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #32479.
HTTPGettercurrently disables HTTP compression across the board. That is correct for chart archive downloads, but it also means repository index requests never advertise gzip support.This change keeps chart downloads unchanged and narrowly opts
index.yamlrequests into gzip by:Accept-Encoding: gziponly forindex.yamlrequestsThat allows large repository indexes to be transferred compressed without changing
.tgzdownload behavior.Special notes for your reviewer:
This is intentionally narrow. Enabling HTTP compression globally in
HTTPGetterwould risk transparently decompressing chart archives when servers sendContent-Encoding: gzip.Validation run locally:
go test ./pkg/repo/v1 -run TestDownloadIndexFile/should_accept_gzip-compressed_index_responses -count=1go test ./pkg/getter ./pkg/repo/v1 -count=1PATH="$(go env GOPATH)/bin:$PATH" make test-styleIf applicable:
docs neededlabel should be applied if so)