feat: helm performance improvement by deep copying coalesce globals#31841
Open
AnubhavT007 wants to merge 1 commit intohelm:mainfrom
Open
feat: helm performance improvement by deep copying coalesce globals#31841AnubhavT007 wants to merge 1 commit intohelm:mainfrom
AnubhavT007 wants to merge 1 commit intohelm:mainfrom
Conversation
pull-request-size
bot
added
the
size/XS
Signed-off-by: antyagi <anubhav.tyagi@soprabanking.com>
anubhav-tyagi1
force-pushed
the
feat/helm-performance-improvement
branch
from
48d81c5 to
f9054a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR uses deep copy in coalesceGlobals instead of shallow copy.
Due to this change, helm command's performance got massive improvement (both in time & memory consumption)
Special notes for your reviewer:
This change is being used within my company since a very long time (was being used in helm v3 also), so I suggest to make this change in helm v4 which will be a huge performance improvement.
Moreover, I am below sharing some performance difference while executing helm commands with/without this perf change on big bundles of my company (can not share the bundle).
If applicable:
docs neededlabel should be applied if so)