Skip to content

Create github CODEOWNERS for core maintainer HIP management #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gjenkins8
Copy link
Member

@gjenkins8 gjenkins8 commented Nov 10, 2024

  • make @helm/helm-org-maintainers default owner
  • allow @helm/helm-org-maintainers and @helm/helm-core-maintainers (either may approve) for hips/ dir
  • finally, ensure @helm/helm-org-maintainers remains CODEOWNERS owner

(for the CODEOWNERS to be fully valid, @helm/helm-core-maintainers needs to be added for write access; currently it does not)

Signed-off-by: George Jenkins <[email protected]>
Signed-off-by: George Jenkins <[email protected]>
@gjenkins8 gjenkins8 marked this pull request as ready for review November 11, 2024 00:14
Signed-off-by: George Jenkins <[email protected]>
Signed-off-by: George Jenkins <[email protected]>
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work George.

Though I agree most HIPs are for Helm core, HIPs can and sometimes are proposals for other areas of the Helm project. hip-0001 makes clear who can approve a HIP:

The final authority for proposal approval is the project maintainers responsible for the project the proposal is aimed at

I do think this is an improvement, though I would just ask that Helm core maintainers bear in mind when a proposal is meant for another area of the Helm project.

Can you update this repo's CONTRIBUTING.md in this PR with the proposed changes including clarifying this note above so the process is clear?

To-do after merging:

  • Once this PR merges, we will need to give @helm/helm-core-maintainers write access to this repo for this PR to have any effect.

@scottrigby
Copy link
Member

Fun follow-up idea: hips could be in folders (or have a file naming convention, like hip-9999-AREA) to automatically map this to certain areas of the project, according to maintainer groups/subprojects. We could revisit after either #394 or #156 are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants