-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ZEGEMA PARADISE and PROVIDENCE planets.json fields #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a typo.
weather_effects can be renamed to something else if needed.
syncing updates
correcting Zegema Paradise and Providence entries, they didn't get updated at first.
dealloc
previously approved these changes
Dec 7, 2024
In addition, adding the new planet effects that where added to the game just now. |
dealloc
previously approved these changes
Dec 10, 2024
fixing 1228 to have the proper galacticEffectID
finally found what effect 1228 was- it was the map marker for the Meridian Black Hole.
dealloc
previously approved these changes
Dec 21, 2024
New effect, added December 24th.
chatterchats
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZEGEMA PARADISE and PROVIDENCE did not get updated properly when the other entries in planets where updated with the type and weather_effects fields.
This Pull Request corrects that, adding the correct type and weather_effects fields to these planets.