Galactic effects & correcting new planet enviornmental effects

[CrosswaveOmega]

This Pull Request contains the known effects of all observed Active Planet Effects, switches biome keys to the internal game names for the sake of consistency, and corrections for the temperature alternating planets.

[chatterchats]

Regarding the planets.json - While acknowledging that out data is also potentially mistaken, how are you determining which evnironmental effects are on the the planet? For Example, Klen Dath II (planet_001) has both intense heat and extreme cold on your version. (This is in addition to the fact that the only environmental effect it should have is Sandstorm as per the helldiversData repo by Shalzuth)

[CrosswaveOmega]

@chatterchats
One of the patches on September 17th (patch 01.001.100) internally changed the way the game handles temperature. It's now specific to the weather settings instead of the environmental effects.

For example, on Klen Dath II and planets that share it's settings, the extreme heat/cold modifiers is now applied whenever the time in the mission area is day/night respectively. I built a special script to get this mapped.

[lambstream]

Please update the coding style. You're using spaces instead of tabs.

[chatterchats]

@chatterchats One of the patches on September 17th (patch 01.001.100) internally changed the way the game handles temperature. It's now specific to the weather settings instead of the environmental effects.

For example, on Klen Dath II and planets that share it's settings, the extreme heat/cold modifiers is now applied whenever the time in the mission area is day/night respectively. I built a special script to get this mapped.

@CrosswaveOmega
Hm... That change may indicate we need to restructure, since that field has pretty much always correlated to the planet's gameplay_modifiers. I'll talk w/ the other folks about this to decide how we want to move forward with that

Just a brief heads-up, the json repo is formatted using 4-width tabs and not spaces, if you could please get that corrected ^^

[CrosswaveOmega]

I am attempting to get the formatting resolved in my editor, hopefully this corrects it.

[chatterchats]

I am attempting to get the formatting resolved in my editor, hopefully this corrects it.

Looks a lot better!, Thank you

[dealloc]

@chatterchats requesting your opinion here, but would sorting the json files by key alphabetically be feasible?
would make future PR's/diffs a little easier to maintain as now things seem to jump around between updates