Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix L'estrade name references in JSON #34

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix L'estrade name references in JSON #34

merged 1 commit into from
May 1, 2024

Conversation

paulleonartcalvo
Copy link
Contributor

Names were wrong based on the game client so I corrected

@dealloc dealloc mentioned this pull request May 1, 2024
Closed
@dealloc dealloc linked an issue May 1, 2024 that may be closed by this pull request
[BUG]: L'estrade sector name incorrect #33
Closed
dealloc
dealloc approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@dealloc dealloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as far as I can tell, letting Chats do final review

@chatterchats chatterchats merged commit 12c1774 into helldivers-2:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatterchats chatterchats chatterchats approved these changes

@dealloc dealloc dealloc approved these changes

Assignees

@chatterchats chatterchats

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: L'estrade sector name incorrect
3 participants
@paulleonartcalvo @dealloc @chatterchats